-
Notifications
You must be signed in to change notification settings - Fork 18
Add customizable storage disk support #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Update private key filename config variable - Remove default values, as that is handled in the config file
- Add config variable to specify the storage disk - Implement storage_path config variable - Updated storage_path config variable name to be more clear. Also fixes the untended effects for people who actually set this variabe (but never did anything) - Add test coverage for both
@RichardStyles Any chance you could review and merge this PR? Thanks. |
@RichardStyles Same question as npostman :s |
@RichardStyles, let us know. Currently cannot use package with Vapor (AWS Lambda) as the key would just get lost. :) |
Trying to play catch up with these. Apologies for the delay - it's been a fun year. My initial thought, you can create your own handler class and set provided it follows the RsaKeyHandler implementation.
But this PR would make it easier to manage storage - so will look at this as it makes sense to have. |
Welcome back 😄 And thanks for having a look. |
@RichardStyles click merge |
This feature adds a configurable disk name for storage.
Idea and most work credits go to @forxer. I made a small change to make it actually work, and added test support.
In the process I also made the store path config variable work.