Skip to content

Conversation

npostman
Copy link

This feature adds a configurable disk name for storage.

Idea and most work credits go to @forxer. I made a small change to make it actually work, and added test support.

In the process I also made the store path config variable work.

npostman added 3 commits May 31, 2021 15:26
- Update private key filename config variable
- Remove default values, as that is handled in the config file
- Add config variable to specify the storage disk
- Implement storage_path config variable
- Updated storage_path config variable name to be more clear. Also fixes the untended effects for people who actually set this variabe (but never did anything)
- Add test coverage for both
@npostman
Copy link
Author

@RichardStyles Any chance you could review and merge this PR?

Thanks.

@mylemans
Copy link

@RichardStyles Same question as npostman :s

@bloomlive
Copy link

@RichardStyles, let us know. Currently cannot use package with Vapor (AWS Lambda) as the key would just get lost. :)

@RichardStyles
Copy link
Owner

Trying to play catch up with these. Apologies for the delay - it's been a fun year.

My initial thought, you can create your own handler class and set provided it follows the RsaKeyHandler implementation.

 /**
     * This class can be overridden to define how the RSA keys are stored, checked for
     * existence and returned for Encryption and Decryption. This allows for keys to
     * be held in secure Vaults or through another provider.
     */
    'handler' => \RichardStyles\EloquentEncryption\FileSystem\RsaKeyStorageHandler::class,

But this PR would make it easier to manage storage - so will look at this as it makes sense to have.

@npostman
Copy link
Author

Welcome back 😄 And thanks for having a look.

@goyote
Copy link

goyote commented Oct 25, 2022

@RichardStyles click merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants