Skip to content

Conversation

bvdmitri
Copy link
Member

Some methods were missing

@bvdmitri bvdmitri requested a review from wouterwln June 10, 2025 12:02
Copy link
Contributor

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #16 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (fa2f106) to head (c3bb56d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   83.33%   84.67%   +1.34%     
==========================================
  Files           2        2              
  Lines         114      124      +10     
==========================================
+ Hits           95      105      +10     
  Misses         19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

🤖 Code Formatting

Your PR still has some code formatting issues. I've updated PR #16 with the necessary formatting changes.

You can merge that PR into this branch to fix the code style check.

Alternatively, you can run make format locally and push the changes yourself.

Check if the graph is bipartite.
"""
function is_bipartite(g::BipartiteFactorGraph)
return Graphs.is_bipartite(g.graph)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to return true for is_bipartite? Is it even possible to create a non-bipartite graph under the hood?

@bvdmitri bvdmitri merged commit cb45fe5 into main Jun 11, 2025
6 checks passed
@bvdmitri bvdmitri deleted the graph-api-patch branch June 11, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants