Subprocesses improvements #1918
Merged
+6
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mostlyobvious
commented
Oct 14, 2025
mostlyobvious
commented
- Dead code
- Drop bundler isolation
- Make outputs of subprocess configurable
- Silence loud noise from subprocess
- Make stderr silent by default
This was added purely to run `bundler/inline` within a spec executed under a different bundle. It was supposed to clear any previous bundler influence in the subprocess. Unfortunately due to the way we run bundler on CI (config --deploymment 'true') this still doesn't work 100% correctly — and cannot resolve gems confliciting with the bundled ones (uri, securerandom, ...). So let's not pretend it would work and get rid of it.
For example one can detach stderr and never see warnings emitted there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.