[0.6.0-UT] Transferring Multi-GPU tests #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arech8
reviewed
Aug 12, 2025
build/rocm/run_multi_gpu.sh
Outdated
| --reruns 3 \ | ||
| tests/pmap_test.py | ||
| # Multi-GPU test files | ||
| MULTI_GPU_TESTS=( |
There was a problem hiding this comment.
I presume, this variable must have the same definition in both runners, right?
Then perhaps you could just refactor it to a separate script that both runners will source to get the same variable value?
This would simplify and robustify maintenance of the tests..
There was a problem hiding this comment.
oh, the second runner is a python script actually... That makes things more annoying, but still doable. I fear, definitions could easily go out of sync if left as is. Even now it's hard to validate they are in sync..
There was a problem hiding this comment.
Any thoughts on this, @gulsumgudukbay ?
charleshofer
approved these changes
Aug 14, 2025
Arech8
approved these changes
Aug 15, 2025
thanks! yep, I learned it new as well, such a nice tool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests that require multiple GPUs were executed in the run_single_gpu.py script, which was an issue because this script only dedicates a single GPU per each test.
Therefore, this PR identified the tests that require multiple GPUs and migrated them to run_multi_gpu.sh script and excluded those tests from the run_single_gpu.py script.
After this is merged, the abort support that lives in run_single_gpu.py will be also added to run_multi_gpu.sh script.