Fix GPU handle pool singleton aliasing with tag-based template separa… #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phambinhfin
force-pushed
the
phambinh/handle-pool-singleton-separation
branch
from
33c4da7 to
09f9ed0
Compare
draganmladjenovic
requested changes
Aug 1, 2025
Arech8
reviewed
Aug 1, 2025
Arech8
requested changes
Aug 1, 2025
phambinhfin
force-pushed
the
phambinh/handle-pool-singleton-separation
branch
4 times, most recently
from
2b8cd1b to
7b8bf77
Compare
…tion Problem: - BLAS and SOLVER handle pools were sharing the same static singleton instance - C++ template instantiation created only one pool when HandleType/StreamType were identical - This caused resource contamination between hipBLAS and hipSOLVER operations - Led to potential memory corruption and unexpected GPU library behavior Solution: - Added Tag template parameter to HandlePool class with default DefaultTag - Introduced BlasTag and SolverTag for unique pool instantiations - Updated all handle pool typedefs to use three-argument template - Each tag type now gets its own static singleton pool instance
phambinhfin
force-pushed
the
phambinh/handle-pool-singleton-separation
branch
from
7b8bf77 to
d08b600
Compare
|
Prefer the solution : https://github.com/ROCm/jax/pull/525/files |
Ruturaj4
approved these changes
Aug 1, 2025
|
Yeah, #525 is better. I think this one can just be discarded |
|
@phambinhfin please close the PR and delete the branch if it's not needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion
Problem:
Solution: