Skip to content

Fix get_rocm_version to skip tests if installation is missing #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

Fix get_rocm_version to skip tests if installation is missing #456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions jax/_src/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,11 +398,13 @@ def is_device_rocm():
def get_rocm_version():
rocm_path = os.environ.get("ROCM_PATH", "/opt/rocm")
version_path = Path(rocm_path) / ".info" / "version"
if not version_path.exists():
raise FileNotFoundError(f"Expected ROCm version file at {version_path}")
version_str = version_path.read_text().strip()
major, minor, *_ = version_str.split(".")
return int(major), int(minor)
try:
version_str = version_path.read_text().strip()
major, minor, *_ = version_str.split(".")
return int(major), int(minor)
except FileNotFoundError:
warnings.warn("ROCm was not installed")
raise unittest.SkipTest("ROCm was not installed")

def is_device_cuda():
return 'cuda' in xla_bridge.get_backend().platform_version
Expand Down
Loading