Skip to content

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Aug 27, 2025

Expose (hidden until now) loading and error fields of async computed signal

Copy link

changeset-bot bot commented Aug 27, 2025

🦋 Changeset detected

Latest commit: 0dbff0a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo marked this pull request as draft August 27, 2025 15:34
@Varixo Varixo force-pushed the v2-async-computed-polish branch 3 times, most recently from 24ba428 to 96c66b9 Compare August 27, 2025 15:36
@Varixo Varixo marked this pull request as ready for review August 27, 2025 15:36
@Varixo Varixo moved this from Backlog to Waiting For Review in Qwik Development Aug 27, 2025
@Varixo Varixo force-pushed the v2-async-computed-polish branch from 96c66b9 to 0dbff0a Compare August 27, 2025 15:42
Copy link

pkg-pr-new bot commented Aug 27, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7876
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7876
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7876
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7876

commit: 0dbff0a

Copy link
Contributor

github-actions bot commented Aug 27, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 0dbff0a

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we really need an error field, let alone a signal for it? Shouldn't errors be never happening?

@Varixo
Copy link
Member Author

Varixo commented Aug 28, 2025

I wonder if we really need an error field, let alone a signal for it? Shouldn't errors be never happening?

if you call fetch inside async computed and fetch fails, then I think we should handle this somehow

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 0a414c0 into build/v2 Aug 28, 2025
20 checks passed
@wmertens wmertens deleted the v2-async-computed-polish branch August 28, 2025 17:20
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants