-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: expose loading and error fields of async computed signal #7876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0dbff0a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
24ba428
to
96c66b9
Compare
96c66b9
to
0dbff0a
Compare
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we really need an error field, let alone a signal for it? Shouldn't errors be never happening?
if you call fetch inside async computed and fetch fails, then I think we should handle this somehow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expose (hidden until now)
loading
anderror
fields of async computed signal