Add support for different datafeed in cloud #359
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81
Description
So far just
lean live deploysupports different datafeed. With this change, the methodget_price_data_handler()fromcloud_brokerage.pycan now parse the datafeed selected in the user input to the expected name in the QC API. In order to make this, the filemodules-1.11.jsonwas also modified to accept one choice from the available datafeed's for certain brokerage. For example, for IB brokerage:{ "id": "ib-data-feed", "type": "input", "value": "", "filters": [ { "condition": { "type": "exact-match", "pattern": "CloudBrokerage", "dependent-config-id": "module-type" } } ], "input-method": "choice", "input-choices": [ "QuantConnect", "Interactive Brokers", "QuantConnect + InteractiveBrokers" ], "prompt-info": "Which one do you want to use: the Interactive Brokers price data feed, QuantConnect price data feed or QuantConnect + InteractiveBrokers price data feed", "help": "The available price data feeds are: Interactive Brokers price data feed, QuantConnect price data feed or QuantConnect + InteractiveBrokers price data feed" },In the same way, the method
get_price_data_handler()was modified to work for other brokerages in the future. Below, it's shown a unit test made to assert this:Finally, unit tests for InteractiveBrokers and Tradier brokerages were made to cover these changes.