-
Notifications
You must be signed in to change notification settings - Fork 3
Add support for columns and page margins #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Friendly bump! |
Thanks for the PR! I'm on vacation currently so will need a bit until I can get to it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I have some smaller comments but in general this already looks quite good :)
Interesting! It seems that LibreOffice and Microsoft Word handle that differently, because the same test in LibreOffice wraps as expected. |
Hm yeah that can happen with different rendering engines. I would create a file with the desired column layout directly in Word, unzip the docx file and then compare the XML inside with what we generate here. If you don't have access to Word, I can also make such a file |
I have Word; I'll finish this up sometime this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now on my end!
I followed the ECMA-376 spec for both columns (definitions/descriptions in §17.6.3 and
17.6.4), and margins (§17.6.11).
Fixes #30.