Skip to content

Conversation

halleysfifthinc
Copy link
Contributor

I followed the ECMA-376 spec for both columns (definitions/descriptions in §17.6.3 and
17.6.4), and margins (§17.6.11).

Fixes #30.

@halleysfifthinc
Copy link
Contributor Author

Friendly bump!

@jkrumbiegel
Copy link
Collaborator

Thanks for the PR! I'm on vacation currently so will need a bit until I can get to it

Copy link
Collaborator

@jkrumbiegel jkrumbiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I have some smaller comments but in general this already looks quite good :)

@jkrumbiegel
Copy link
Collaborator

I fixed a small bug with the kwargs but it looks like the custom column widths don't yet work. If I repeat the text in the test case it looks like this:

image

@jkrumbiegel
Copy link
Collaborator

It still doesn't look correct, now there's one smaller column which is progress, but the text doesn't go into the other one, suggesting there's something wrong with the generated xml
image

@halleysfifthinc
Copy link
Contributor Author

Interesting! It seems that LibreOffice and Microsoft Word handle that differently, because the same test in LibreOffice wraps as expected.

@jkrumbiegel
Copy link
Collaborator

Hm yeah that can happen with different rendering engines. I would create a file with the desired column layout directly in Word, unzip the docx file and then compare the XML inside with what we generate here. If you don't have access to Word, I can also make such a file

@halleysfifthinc
Copy link
Contributor Author

I have Word; I'll finish this up sometime this week.

Copy link
Collaborator

@jkrumbiegel jkrumbiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now on my end!

@jkrumbiegel jkrumbiegel merged commit 8d4b2ec into PumasAI:main Sep 4, 2025
7 checks passed
@halleysfifthinc halleysfifthinc deleted the columns branch September 4, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support setting columns and page margins

2 participants