306 broken pipe issues on Windows machines in examples #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nic-Ma
reviewed
Apr 26, 2020
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Thanks very much for your quick PR.
Could you please help move the main logic to a function? Just follow the PyTorch recommended way.
Others look good to me.
Thanks.
Nic-Ma
approved these changes
Apr 26, 2020
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Looks good to me now.
Thanks again for your PR.
Contributor
Author
|
Thank you for pointing out the PyTorch recommended fashion :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306.
Description
Fixed broken pipe issue on Windows machine in examples by adding
if __name__ == '__main__'. Another possible fix would be to set the number of workers in DataLoader to 0.Also fixed a typo in a notebook.
Status
Ready
Types of changes