58-implement-transform-adaptor-2: Re-adding work via new branch as th… #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 4, 2020 15:26
…e original branch has become un-rebasable
wyli
reviewed
Mar 4, 2020
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
looks like this is not supported, not sure if it is expected:
def foo(image, *a):
return image + 1, a
d = {'image': 2, 'a': 'test'}
dres = adaptor(foo, ('image', 'a'))(d)
print(dres)
Contributor
Author
|
It isn't currently supported. Can we go ahead with it now and address that subsequently? |
wyli
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #58
A re-commit of the work in question as the original branch '58-implement-transform-adaptor' has become un-rebaseable
Description
Addition of several adaptor methods that allow use of transforms from different libraries with the torchvision and monai Compose functions.
Status
Ready
Types of changes