Fix metadata returning semantic versioning #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gijsreyn
force-pushed
the
fix-metadata-version
branch
from
2e9c8ae to
b1695d3
Compare
SteveL-MSFT
requested changes
Aug 30, 2025
Gijsreyn
force-pushed
the
fix-metadata-version
branch
from
b1695d3 to
cdb0ba7
Compare
SteveL-MSFT
approved these changes
Aug 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR adds a place in the library's context to hold the dsc CLI's version number. The version is set at startup from the CLI. For backwards compatibility, it falls back to the library's own version. Before this change, the version in the metadata came from the library crate, which could be different then DSC's CLI version.
PR Context
Fix #1065