Change utcNow() tests to use regex for validation
#1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the utcNow() function tests to use regex validation instead of direct datetime comparisons, addressing race condition issues where timing differences between the function call and PowerShell equivalent could cause test failures.
- Replace direct datetime value comparisons with regex pattern matching
- Add comprehensive regex patterns for different datetime formats
- Include additional test case for ISO format with seconds
Co-authored-by: Copilot <[email protected]>
tgauth
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
utcNow()tests have proven to be fragile due to a race condition of when the function is called and when the PowerShell equivalent used for comparison is called. In particularly if the second, minute, or hour just clicked over, then it fails.Since we are primarily focused on the format, use a regex to verify instead of trying to verify the value.