Made new plots incorporating first review of adaptivity paper #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks like codecov.io is dead again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change a lot of configurations for this, but not much in terms of functionality. I know it's a lot of mess. I apologise if anyone actually tries to review it :D I should have refactored at the time, but now I don't have time..
I also updated a reference for the exact solution of NLS and improved efficiency of the stats helper slightly. Van der Pol now allows relative Newton tolerance.
Also, my git hook applies black to any file that is staged in my commits. Therefore, when I merge master, it reformats some of the files in playgrounds or tests that are not forced to be correctly formatted at that time. This includes two files in the DAE playground.
Finally, I added a small test that solver and RHS evaluation in Quench are consistent.