Skip to content

Conversation

@jakob-fritz
Copy link
Collaborator

Fixed typo in waiting for other pipeline and corrected issue with providing artifacts.

Now the website builds successfully (not uploaded, because this is done only from main branch).

Some tests were flaky for unknown reasons (failed in first go, but finished successfully in second approach)

@jakob-fritz
Copy link
Collaborator Author

The changes in CONTRIBUTING.md were just done to trigger the first CI-run for checking. Could be reverted, but now satisfies the md-linter more than the previous version.

@jakob-fritz jakob-fritz self-assigned this Jul 25, 2024
@brownbaerchen
Copy link
Contributor

brownbaerchen commented Jul 25, 2024

LGTM. Which tests are flaky? I now that the PyTorch tutorial test is flaky because I couldn't figure out how to set a random seed there. Did you spot any more?

@jakob-fritz
Copy link
Collaborator Author

LGTM. Which tests are flaky? I now that the PyTorch tutorial test is flaky because I couldn't figure out how to set a random seed there. Did you spot any more?

The PyTorch job failed once (but only one of the python-versions) and the job project_cpu_tests_linux (matrixPFASST, 3.11) failed once.

@jakob-fritz jakob-fritz merged commit 0e60614 into master Jul 25, 2024
@brownbaerchen brownbaerchen deleted the JF_test_ci branch July 25, 2024 09:52
brownbaerchen pushed a commit to brownbaerchen/pySDC that referenced this pull request Jul 29, 2024
And properly provide all artifacts for creation of website
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants