Skip to content

Conversation

@jakob-fritz
Copy link
Collaborator

and exit before submitting a job to a partition where it cannot be picked up by any nodes.

The artifacts are still being tried to be collected (which fails because the files don't yet exist).

As the job fails if no node can run the SLURM-Job, the behaviour is similar to current behaviour, but with earlier failing of the CI-Job, as it does not need to time out.

Creating a warning instead of a failure is currently not possible due to an issue in the jacamar-runner (Issue is opened).

@jakob-fritz jakob-fritz requested a review from pancetta July 4, 2024 06:43
@jakob-fritz jakob-fritz self-assigned this Jul 4, 2024
@codecov
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.83%. Comparing base (18989d3) to head (b31e4fa).
Report is 33 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
+ Coverage   77.38%   77.83%   +0.44%     
==========================================
  Files         327      332       +5     
  Lines       26085    25843     -242     
==========================================
- Hits        20187    20114      -73     
+ Misses       5898     5729     -169     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pancetta pancetta merged commit 965b211 into Parallel-in-Time:master Jul 4, 2024
@jakob-fritz jakob-fritz deleted the Handle_SLURM_Issues branch July 4, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants