docs: hepa door rollers 2 #19370
Open
docs: hepa door rollers 2 #19370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds section on door rollers - Updates images to include module showing door rollers - Images in procedures not updated. They're clear enough that people understand. Don't have the heart to ask Jackson to change these. Save image request capital for the vacuum manifold.
|
As this seems to have passed, will mark it as ready for review. |
ecormany
reviewed
Aug 28, 2025
There was a problem hiding this comment.
This isn't an SVG at all. Should be saved as a PNG.
There was a problem hiding this comment.
This at least has some vector elements, but is probably also better off as a PNG.
docs/hepa-uv/docs/product-specs.md
Outdated
|
|
||
| With early model HEPA/UV modules, fully opening the robot's front door meant scraping it across the top of that module. Eventually, the edge of the HEPA module would scratch and leave scuff marks on the surface of the door. | ||
|
|
||
|  |
There was a problem hiding this comment.
Optional: move this after the next paragraph and do a <figure class="side-by-side"> for a nice visual comparison.
There was a problem hiding this comment.
Yes, let's make it side by side.
Thank you for the suggestion. Applying it now. Co-authored-by: Ed Cormany <[email protected]>
- Removed converted SVGs and replaced with true PNG images. - Make model comparison a side by side image. Removed rounded arrows. Maybe those aren't needed and cause clutter. - Tweak door roller text
ecormany
reviewed
Aug 29, 2025
| HEPA modules manufactured on or after July 2025 include three rollers mounted along its top-front edge. These rollers prevent the HEPA module from damaging the front door when you open it. | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
Ah, so I was actually thinking of doing something like this:
<figure class="side-by-side" markdown>
<figcaption>Newer models have door rollers. Older models do not.</figcaption>
</figure>
There was a problem hiding this comment.
That's good too. I'm assuming this is a class rule that puts 2 separate images side by side. Will do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As my previous PR exploded, this is HEPA Rollers 2: Electric Boogaloo. This PR does 2 things:
It updates the HEPA module instruction manual to include the new rollers (images and text).
It removes the logo image from the front page (
index.md)See RTC-763.
Test Plan and Hands on Testing
Did I break the build? Hopefully not.
Changelog
New renders and illustrations for the manual:
What doesn't change: images in the setup procedure. Let's bank our Jackson image requests for the vacuum manifold. I really don't want to ask him for revisions to these, they're still clear and valid.
Review requests
Make sure I'm not destroying anything.
Risk assessment