Skip to content

Add NonFungibleToken Docs #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 23, 2025
Merged

Add NonFungibleToken Docs #186

merged 21 commits into from
Jul 23, 2025

Conversation

emnul
Copy link
Contributor

@emnul emnul commented Jul 21, 2025

Types of changes

What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Closes #94

This pull requests adds documentation for the NonFungibleToken module

PR Checklist

@emnul emnul requested a review from a team as a code owner July 21, 2025 21:12
@emnul emnul self-assigned this Jul 21, 2025
@emnul emnul added documentation Improvements or additions to documentation needs-review Pull requests which need code review, and approval from maintainers or OpenZeppelin core team. labels Jul 21, 2025
andrew-fleming
andrew-fleming reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs look good! I left a few comments

emnul
emnul commented Jul 23, 2025
View reviewed changes
Copy link
Contributor Author

@emnul emnul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed most recent changes

@emnul emnul requested a review from andrew-fleming July 23, 2025 16:45
andrew-fleming
andrew-fleming approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emnul emnul merged commit 07f07e5 into main Jul 23, 2025
7 checks passed
@andrew-fleming andrew-fleming mentioned this pull request Jul 24, 2025
Closed
@emnul emnul deleted the nft-docs branch August 28, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrew-fleming andrew-fleming andrew-fleming approved these changes

Assignees

@emnul emnul

Labels

documentation Improvements or additions to documentation needs-review Pull requests which need code review, and approval from maintainers or OpenZeppelin core team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add docs for NonFungibleToken module

2 participants

@emnul @andrew-fleming