Skip to content

Conversation

andrew-fleming
Copy link
Contributor

@andrew-fleming andrew-fleming commented Jul 6, 2025

Fixes #39.

PR Checklist

  • Tests
  • Documentation

This PR proposes to implement a basic Ownable module implementation which is easier for prototyping and early development. This also separates regular ownership transfers and unsafe ownership transfers (to contract addresses). If accepted, we should also include a two-step variant for more secure development

@andrew-fleming andrew-fleming requested a review from a team as a code owner July 6, 2025 03:11
Copy link
Contributor

@emnul emnul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Not a whole lot to add on to this given how straightforward the implementation is

@andrew-fleming
Copy link
Contributor Author

andrew-fleming commented Jul 16, 2025

Very nice! Not a whole lot to add on to this given how straightforward the implementation is

Thank you for the review @emnul!

I left a comment on your comment above. I was also thinking it might be better to change the package/dir name to access i.e. contracts/access. The idea being that we can have Ownable and Access Control under the same directory. LMK what you think

(sorry for not doing this earlier in this PR, it just came to mind with the forthcoming change to contracts/token)

@emnul
Copy link
Contributor

emnul commented Jul 16, 2025

I was also thinking it might be better to change the package/dir name to access i.e. contracts/access. The idea being that we can have Ownable and Access Control under the same directory. LMK what you think

Makes sense! Especially since we will be adding even more access modules in the very near term

@andrew-fleming andrew-fleming merged commit 2a1449c into main Jul 16, 2025
7 checks passed
@andrew-fleming andrew-fleming deleted the add-ownable branch July 16, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ownable unshielded

2 participants