-
Notifications
You must be signed in to change notification settings - Fork 12
Add unshielded ownable #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: ⟣ €₥ℵ∪ℓ ⟢ <[email protected]> Signed-off-by: Andrew Fleming <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Not a whole lot to add on to this given how straightforward the implementation is
Thank you for the review @emnul! I left a comment on your comment above. I was also thinking it might be better to change the package/dir name to (sorry for not doing this earlier in this PR, it just came to mind with the forthcoming change to |
Makes sense! Especially since we will be adding even more access modules in the very near term |
Fixes #39.
PR Checklist
This PR proposes to implement a basic Ownable module implementation which is easier for prototyping and early development. This also separates regular ownership transfers and unsafe ownership transfers (to contract addresses). If accepted, we should also include a two-step variant for more secure development