Remove event source check and creation #27
Conversation
This requires elevated privileges which virtual service user doesn't have. GitHub: OpenVPN#26 Signed-off-by: Lev Stipakov <[email protected]>
Signed-off-by: Lev Stipakov <[email protected]>
|
Consider adding better error handling, allow for parts of the process to throw, without killing the whole service. |
|
Does it even make sense to continue if we cannot log? |
This enables OpenVPNService, running under limited virtual service account, to log to event log. GitHub: OpenVPN/openvpnserv2#27 Signed-off-by: Lev Stipakov <[email protected]>
|
Is a log needed? I would prefer for as much as possible keep working on non critical errors. Another assumption that is often wrong is that the OpenVPN installer has been used. Please consider a "portable" use-case. |
Yes, a log is needed. Figuring out later that things failed at some point and can not be debugged because we knew beforehand that we cannot log is inacceptable - so, "not being able to write a log file" is a critical error.
If you want to contribute code for that, and have a usecase that makes sense, you're welcome - but this is not what we are interested in spending time on. We do this for our usecase, which is "the OpenVPN installer is used" (and this seems to be hard enough to get right in all corner cases). |
|
The change to the installer which creates event source: OpenVPN/openvpn-build@1cdee86 |
This enables OpenVPNService, running under limited virtual service account, to log to event log. GitHub: OpenVPN/openvpnserv2#27 Signed-off-by: Lev Stipakov <[email protected]>
This enables OpenVPNService, running under limited virtual service account, to log to event log. GitHub: OpenVPN/openvpnserv2#27 Signed-off-by: Lev Stipakov <[email protected]>
4 participants
No description provided.