perf(sync-closers): improve Close method #1395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
j2rong4cn
force-pushed
the
pr/fix7
branch
2 times, most recently
from
2206fa8 to
37852f7
Compare
j2rong4cn
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR improves the Close method in the SyncClosers type by simplifying the atomic reference counting logic and removing a compare-and-swap loop.
- Replaces a complex compare-and-swap loop with a single atomic decrement operation
- Improves logging to distinguish between reference releases and final closes
- Simplifies the control flow for determining when to perform the final close operation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
最终方案，已经没优化空间了 |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: j2rong4cn <[email protected]>
j2rong4cn
changed the title
xrgzs
approved these changes
Oct 1, 2025
|
ai误我，ai建议我选择AcquireReference竟态的版本，😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
无锁线程安全的SyncClosers最终版本
Close方法的竟态从n次优化到最多2次