refactor(fs): batch remove and rename #174
Conversation
xrgzs
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the file system remove and rename operations to use ID-based operations for improved efficiency and reliability. The changes enable batch operations that can identify files by both ID and name, moving away from name-only identification.
- Added ID field to file objects and created IDName type for batch operations
- Updated fsRemove API to use IDName objects and File-Path header instead of dir parameter
- Fixed batch rename suffix handling for files without extensions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/types/obj.ts | Added id field to Obj interface and created IDName type for batch operations |
| src/utils/api.ts | Refactored fsRemove to use IDName array and File-Path header |
| src/pages/home/toolbar/Delete.tsx | Updated delete operation to pass both id and name |
| src/pages/home/toolbar/BatchRename.tsx | Fixed suffix handling for files without extensions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| export const fsRemove = (dir: string, names: IDName[]): PEmptyResp => { | ||
| return r.post( | ||
| "/fs/remove", | ||
| { names }, | ||
| { | ||
| headers: { | ||
| "File-Path": encodeURIComponent(dir), | ||
| }, | ||
| }, | ||
| ) | ||
| } |
There was a problem hiding this comment.
The function signature still accepts a dir parameter but the API call has changed to use a File-Path header. Consider renaming the parameter to filePath to better reflect its usage as a header value rather than a request body parameter.
Copilot uses AI. Check for mistakes.
参考：refactor:batch remove and rename