build sdist with python 3.12 #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Cadair
approved these changes
Jan 30, 2025
|
Thanks @braingram |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty much a bandaid solution.
Even though the
build_sdistjob in thepublishworkflow sets up python with 3.12:github-actions-workflows/.github/workflows/publish.yml
Line 214 in 3b829fe
It does not provide a python version to
OpenAstronomy/build-python-distwhich is causing it to install and setup python 3.13 (as it defaults to 3.x).This is causing build failures for a package that has a python upper pin that prevents 3.13 (as the CI is otherwise unaware of this pin) due to the 3.x job now defaulting to 3.13:
https://github.com/spacetelescope/jwst/actions/runs/13034242395/job/36361396551?pr=9081
This PR doesn't address the root cause (the CI being unaware of the python pin) but does pass the 3.12 version on to
OpenAstronomy/build-python-distwhich should fix the immediate failures for that package.