Skip to content

Conversation

yonatankarp
Copy link
Contributor

@yonatankarp yonatankarp commented Sep 26, 2025

This commit fixes a bug in the kotlin-spring generator where models defined with additionalProperties would result in uncompileable code. The generated data class was missing the constructor invocation '()' when inheriting from a map type.

A new sample test case has been added to verify the fix and prevent regressions.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@yonatankarp yonatankarp force-pushed the fix-hashmap-generation branch 4 times, most recently from 63dfae1 to e30404e Compare September 26, 2025 14:00
…odels

This commit fixes a bug in the kotlin-spring generator where models
defined with additionalProperties would result in uncompilable code.
The generated data class was missing the constructor invocation '()'
when inheriting from a map type.

This has been corrected to only add parentheses when the parent is a map.

The existing samples have been regenerated to reflect this change.
@yonatankarp yonatankarp force-pushed the fix-hashmap-generation branch from e30404e to 10ee14a Compare September 26, 2025 14:07
@wing328 wing328 added this to the 7.16.0 milestone Sep 27, 2025
@wing328 wing328 merged commit 44a3be1 into OpenAPITools:master Sep 27, 2025
49 checks passed
@yonatankarp yonatankarp deleted the fix-hashmap-generation branch October 2, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants