Skip to content

Conversation

damdam-s
Copy link
Member

migrated from 14.0

@damdam-s damdam-s force-pushed the 17.0-mig-stock_service_level branch from bd158a2 to 21a83ea Compare April 15, 2025 12:21
@damdam-s damdam-s force-pushed the 17.0-mig-stock_service_level branch from 21a83ea to 23fac07 Compare April 15, 2025 12:26
Copy link

@petrus-v petrus-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this migrations

"development_status": "Beta",
"category": "Warehouse Management",
"website": "https://github.com/OCA/wms",
"author": "Pierre Verkest <[email protected]>,"
Copy link
Contributor

@jbaudoux jbaudoux May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just your name here or it should be Foodles?

Suggested change
"author": "Pierre Verkest <[email protected]>,"
"author": "Pierre Verkest,"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this suggestion

Comment on lines +1 to +2
# Copyright 2024 Foodles (http://www.foodles.co).
# @author Pierre Verkest <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just keep copyright line? (same for other files)
You can put additional info in CREDITS file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have already a lot of modules that use this pattern https://github.com/OCA/event/blob/15.0/event_sale_session/models/event_session.py#L3.

I'm fine if it's moved to a credit/author files and maybe with the initial author mentioned.

@jbaudoux is it an OCA convention? do you know why prefer that other ways ?

Also I've the feeling it's not the best moment to change that in a migration PR which add risk to get no response from the initial author and freeze migration task.

Finally we should probably add pre-commit hook to inform developers on that practices and eventually migrate existing case.

my 2cts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As your are the author, it's fine for me if it's fine for you :)
I'm not aware of conventions

@jbaudoux
Copy link
Contributor

/ocabot migration stock_service_level

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 14, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request May 14, 2025
17 tasks
@damdam-s
Copy link
Member Author

@jbaudoux as part of migration, I'm not sure we should do it during the technical migration process.

@petrus-v any idea regarding this as you are the one being credited for this module 😄

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants