-
-
Notifications
You must be signed in to change notification settings - Fork 206
[17.0][MIG] stock_service_level #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
Conversation
bd158a2
to
21a83ea
Compare
21a83ea
to
23fac07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this migrations
"development_status": "Beta", | ||
"category": "Warehouse Management", | ||
"website": "https://github.com/OCA/wms", | ||
"author": "Pierre Verkest <[email protected]>," |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just your name here or it should be Foodles?
"author": "Pierre Verkest <[email protected]>," | |
"author": "Pierre Verkest," |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this suggestion
# Copyright 2024 Foodles (http://www.foodles.co). | ||
# @author Pierre Verkest <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just keep copyright line? (same for other files)
You can put additional info in CREDITS file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have already a lot of modules that use this pattern https://github.com/OCA/event/blob/15.0/event_sale_session/models/event_session.py#L3.
I'm fine if it's moved to a credit/author files and maybe with the initial author mentioned.
@jbaudoux is it an OCA convention? do you know why prefer that other ways ?
Also I've the feeling it's not the best moment to change that in a migration PR which add risk to get no response from the initial author and freeze migration task.
Finally we should probably add pre-commit hook to inform developers on that practices and eventually migrate existing case.
my 2cts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As your are the author, it's fine for me if it's fine for you :)
I'm not aware of conventions
/ocabot migration stock_service_level |
This PR has the |
migrated from 14.0