Skip to content

Conversation

handrews
Copy link
Member

@handrews handrews commented Mar 29, 2025

This is relevant for a soon-to-be posted OAS 3.2 PR. See Discussion #4171.
MDN has much more readable text/event-stream documentation than WHATWG.

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

@handrews handrews added the script Pull requests that update Bash or JavaScript code label Mar 29, 2025
@handrews handrews requested review from a team as code owners March 29, 2025 00:30
@ralfhandl
Copy link
Contributor

@handrews Would you mind adding this to the test fixture and the expected output, similar to

```uritemplate
https://foo.com/bar{?baz*,qux}
```

and

<pre class="nohighlight" tabindex="0"><code>https://foo.com/bar{<span class="hljs-attr">?baz*</span>,<span class="hljs-attr">qux</span>}
</code></pre>

That way you can verify locally in the browser whether the expected output has the desired visual appearance.

Just

  • Add new code block to basic-new.md
  • npm test shows expected (and missing) HTML snippet in red
  • Copy expected HTML snippet from test output to basic-new.html
  • npm test shows green (if you copied correctly)
  • View basic-new.html in browser to verify visual appearance
  • Rinse and repeat

@handrews handrews merged commit 2a2627f into OAI:main Mar 30, 2025
2 checks passed
@handrews handrews deleted the event-stream-hljs branch March 31, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
script Pull requests that update Bash or JavaScript code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants