Stop using /WarnAsError in source-build CI #6867
Merged
+2
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nigusu-Allehu
approved these changes
Oct 17, 2025
nkolev92
approved these changes
Oct 17, 2025
|
backport to release/7.0x |
|
/backport to release/7.0.x |
|
Started backporting to release/7.0.x: https://github.com/NuGet/NuGet.Client/actions/runs/18604839580 |
|
@Nigusu-Allehu an error occurred while backporting to "release/7.0.x", please check the run log for details! GitHub Actions is not permitted to create or approve pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: CI builds
Description
NuGet.Client already sets TreatWarningsAsErrors via Directory.Build.props, and MSBuild's
/WarnAsErrordoesn't respect MSBuild properties likeWarningsNotAsErrors, so we don't use it intentionally.This PR makes the "source build" CI job consistent with everything else.
Other .NET repos don't have a
eng/dotnet-build/directory, it appears to be something specific to NuGet.Client, so I don't think it'll cause problems with Arcade.PR Checklist
Added testsN/ALink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.N/A