Factor out a new DesugaredEnv from DerivationBuildingGoal
#13850
+158
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
factor-out-drv-env-desugar
branch
2 times, most recently
from
469869d to
7f5fee4
Compare
kjeremy
reviewed
Aug 28, 2025
Ericson2314
force-pushed
the
factor-out-drv-env-desugar
branch
from
443ffed to
d6aa173
Compare
xokdvium
reviewed
Aug 28, 2025
Ericson2314
force-pushed
the
factor-out-drv-env-desugar
branch
6 times, most recently
from
1c19f3f to
7c3a11e
Compare
xokdvium
reviewed
Aug 28, 2025
Now we have better separation of the core logic --- an integral part of the store layer spec even --- from the goal mechanism and other minutiae. Co-authored-by: Jeremy Kolb <[email protected]>
Ericson2314
force-pushed
the
factor-out-drv-env-desugar
branch
from
7c3a11e to
53c31c8
Compare
xokdvium
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now we have better separation of the core logic --- an integral part of the store layer spec even --- from the goal mechanism and other minutiae.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.