Fix ParsedURL handling of %2F in URL paths
#13838
Conversation
github-actions
bot
added
store
Ericson2314
force-pushed
the
parse-url-path
branch
from
2a48d74 to
c310b33
Compare
src/libfetchers/git-lfs-fetch.cc
Outdated
| // FIXME %2F encode slashes? Does this command take/accept percent encoding? | ||
| args.push_back(urlPathToCanonPath(url.path).abs()); |
There was a problem hiding this comment.
@kip93 as an LFS connoisseur, can you shed some light on this?
There was a problem hiding this comment.
Interesting question! I can't find any info on the server spec (neither here nor here) nor in the client docs either (here); and even digging through their tests I can't find anything, nor digging through reported issues. From what I see they are using go standard libraries though, so it's quite possible that this should support escape encoding.
I believe the best way to figure this out for sure is to test it. I can add a test to the git-lfs suite to figure out the behaviour and ensure we don't break anything in the future.
xokdvium
force-pushed
the
parse-url-path
branch
2 times, most recently
from
39d6ad6 to
7964c36
Compare
xokdvium
force-pushed
the
parse-url-path
branch
2 times, most recently
from
5d84cbf to
cb477b5
Compare
| : TarArchive{*source}; | ||
| : TarArchive{*source}; |
There was a problem hiding this comment.
lol, we should probably teach clang-format not to do this some day :)
xokdvium
force-pushed
the
parse-url-path
branch
2 times, most recently
from
32d8035 to
988d4fe
Compare
xokdvium
force-pushed
the
parse-url-path
branch
from
988d4fe to
4ad64a5
Compare
Ericson2314
force-pushed
the
parse-url-path
branch
from
4ad64a5 to
f38a388
Compare
See the new extensive doxygen in `url.hh`. This fixes fetching gitlab: flakes. Paths are now stored as a std::vector of individual path segments, which can themselves contain path separators '/' (%2F). This is necessary to make the Gitlab's /projects/ API work. Co-authored-by: John Ericson <[email protected]> Co-authored-by: Sergei Zimmerman <[email protected]>
xokdvium
force-pushed
the
parse-url-path
branch
from
f38a388 to
c436b7a
Compare
There was a problem hiding this comment.
(Self-approve but this was reviewed and implemented together with @Ericson2314)
Motivation
See the new extensive doxygen in
url.hhContext
New unit test of gitlab URL original from #13829.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.