libutil, libexpr: #10542 abstract over getrusage for getting cpuTime stat and implement windows version #13767
+69
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xokdvium
reviewed
Aug 16, 2025
xokdvium
reviewed
Aug 16, 2025
xokdvium
requested changes
Aug 16, 2025
ethanavatar
force-pushed
the
master
branch
2 times, most recently
from
a14edaa to
e9ff717
Compare
edolstra
reviewed
Aug 18, 2025
Ericson2314
approved these changes
Aug 24, 2025
|
Thanks for this! Yeah I assume it's fine to just throw now. And only if we see it failing in practice do we need to worry about adding code to catch the failure. |
|
Many thanks, @Ericson2314 and others for bearing with me and looking through this pretty minor change. |
xokdvium
requested changes
Aug 24, 2025
auto-merge was automatically disabled
August 25, 2025 01:41
Head branch was pushed to by a user without write access
…Time stat and implement windows version Update src/libutil/windows/current-process.cc Prefer `nullptr` over `NULL` Co-authored-by: Sergei Zimmerman <[email protected]> Update src/libutil/unix/current-process.cc Prefer C++ type casts Co-authored-by: Sergei Zimmerman <[email protected]> Update src/libutil/windows/current-process.cc Prefer C++ type casts Co-authored-by: Sergei Zimmerman <[email protected]> Update src/libutil/unix/current-process.cc Don't allocate exception Co-authored-by: Sergei Zimmerman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation is to move towards Nix on Windows.
libexprusesgetrusagefrom thesys/resource.hUnix header to get the current process's running duration. This PR creates a new function inlibutilwhich has both a Unix implementation and a new Windows implementation, and removes several conditional compile guards related to getting the cpu-time on Windows.The expected behavior is entirely unchanged because Nix doesn't target Windows yet.
The test suite is passing on my machine, but I did not do anything to test the change itself.