Add German Support #4824
Add German Support #4824
Conversation
Add German
add german
|
I'll leave this here for a few days and see if any other German speakers have thoughts |
|
The translation looks good as far as I can tell. @lastsamurai26 Just a tip, you should work on your commit messages :) -> https://www.conventionalcommits.org/ |
Thank you, I'll make a note of that. :-) |
fhennig42
left a comment
fhennig42
left a comment
There was a problem hiding this comment.
I was waiting for the CI to build my PR, so I took a look into this one while waiting for the build.
Even though I'm not a nginx contributor/maintainer (yet) I would suggest taking a look into my suggestions before merging/approving the PR.
frontend/src/locale/src/de.json
Outdated
| "defaultMessage": "Maximum ist {max}" | ||
| }, | ||
| "error.min-character-length": { | ||
| "defaultMessage": "Die mainimale Länge beträgt {min} Zeichen{min, plural, one {} other {s}}" |
There was a problem hiding this comment.
same typo from above, is this file autogenerated?
There was a problem hiding this comment.
yes but not from me
the dev enviroment from nginx re generate the files after each chang
| "defaultMessage": "We are sorry but the page you are looking for was not found" | ||
| }, | ||
| "notfound.title": { | ||
| "defaultMessage": "Oops… You just found an error page" | ||
| }, | ||
| "notification.error": { | ||
| "defaultMessage": "Error" | ||
| }, |
There was a problem hiding this comment.
=( Yes, unfortunately, because I couldn't find a suitable translation. And this one sounds okay to me as a German speaker.
|
Thank you for checking, but it is strange why the parts are in there, as I did not use the tool. To be honest, I hate AI systems or tools. However, I suspect that the dev environment where I translated everything had something installed that caused this. I will check this later at work, as this was a dev environment from work. I didn't translate the last three points in your suggestion because, strangely enough, I couldn't find them in nginx. If you have a suggestion, I'd be happy to hear it. I'm not sure whether your suggestions will be accepted automatically. :( I do work with git, but mostly on my own. |
fix: typo fix: translate Location with Pfad
fix: typo mainimale should be minimale
fix: typo dark and light mode
fix: typo
fix: translation "Umgangssprachlich"
fix: typos
Fix: German translations
|
Docker Image for build 4 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
4 participants
@jc21
I finally managed to install the Dev environment.
Here is the German translation.
I tested it and adjusted a few things, but it's difficult to do this accurately in German.
In German, we say
"Bist du dir sicher das du diese Zugriffsliste löschen möchtest?"
in english is it always this - Are you sure you want to delete this Access List?
"Bist du dir sicher das du diesen Proxy Host löschen möchtest?"
in english aswell this - Are you sure you want to delete this Proxy Host?
so i did this "diese(n)" i hope this is ok