Skip to content

Unnecessary manifest_typings.json entry for embedded:network/* causes warning #1365

@cmidgley

Description

@cmidgley

Build environment: Windows (problem likely occurs on all)
Moddable SDK version: Latest released as of today (any within last six months)
Target device: Win, ESP32

Description
When compiling TypeScript and using examples/manifest_typings.json you get a warning on each build:

# warning: no modules match: c:\moddable\typings\embedded_network\*!

This is because six months ago a change was made that added:

"embedded:network/*": [
	"$(TYPINGS)/embedded_network/*"
]

However, no type files are located at that location (they are all in sub-directories and specifically included in the typings).

Removing this line from examples/manifest_typings.json continues to compile TypeScript but without the warning message.

Steps to Reproduce

  1. Set up a TypeScript app that has a manifest.json that includes:
	"include": [
		"$(MODDABLE)/examples/manifest_typings.json",
	],
  1. Compile with mcconfig
  2. See warning in first line output

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions