Skip to content

Conversation

briandonahue
Copy link
Contributor

Summary:

Closes #1392

Add field value to notice. Note, does not change casing of filename field as everywhere else is using the lowercase version.

Expected behavior:

Should show the offending value.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@github-actions
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@briandonahue
Copy link
Contributor Author

Leaving this as a draft for now as it has some uncommitted changes that will be added in another PR, that will fix #1394

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: b448bef
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@briandonahue briandonahue marked this pull request as ready for review April 25, 2023 17:35
@briandonahue
Copy link
Contributor Author

@isabelle-dr since that bug is resolved, this is ready for review. Let me know your thoughts on the filename casing as mentioned here

@isabelle-dr isabelle-dr requested a review from davidgamez April 25, 2023 19:28
@isabelle-dr
Copy link
Contributor

Will have a look shortly, thank you.
We'll also need a review from @davidgamez :)

@isabelle-dr isabelle-dr self-requested a review April 25, 2023 19:29
@briandonahue briandonahue force-pushed the issue/1392-mixed-case-notice branch from f5a22a3 to 84ebb32 Compare April 25, 2023 22:31
@briandonahue briandonahue deleted the issue/1392-mixed-case-notice branch April 25, 2023 22:35
@briandonahue briandonahue reopened this Apr 25, 2023
@briandonahue
Copy link
Contributor Author

@davidgamez I think this is fixed now. I think I had to pull in some of Kevin's changes to fix an issue I was having, but then afterward could not replicate the issue, so now I've removed the changes, and this should just be the original PR changes.

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1426 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1426 sources (~0 %) are corrupted.
Commit: 8f4101c
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez
Copy link
Member

@davidgamez I think this is fixed now. I think I had to pull in some of Kevin's changes to fix an issue I was having, but then afterward could not replicate the issue, so now I've removed the changes, and this should just be the original PR changes.

Great, thanks! Approving now!

@davidgamez davidgamez merged commit 61e4a45 into master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mixed case validation notice schema is incomplete

3 participants