-
Notifications
You must be signed in to change notification settings - Fork 112
fix: add field value to mixed case notice #1393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
1af2444
to
f5a22a3
Compare
Leaving this as a draft for now as it has some uncommitted changes that will be added in another PR, that will fix #1394 |
✅ Rule acceptance tests passed. |
@isabelle-dr since that bug is resolved, this is ready for review. Let me know your thoughts on the |
Will have a look shortly, thank you. |
web/service/src/main/java/org/mobilitydata/gtfsvalidator/web/service/Main.java
Show resolved
Hide resolved
f5a22a3
to
84ebb32
Compare
@davidgamez I think this is fixed now. I think I had to pull in some of Kevin's changes to fix an issue I was having, but then afterward could not replicate the issue, so now I've removed the changes, and this should just be the original PR changes. |
✅ Rule acceptance tests passed. |
Great, thanks! Approving now! |
Summary:
Closes #1392
Add field value to notice. Note, does not change casing of
filename
field as everywhere else is using the lowercase version.Expected behavior:
Should show the offending value.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything