Skip to content

Conversation

Algiane
Copy link
Member

@Algiane Algiane commented Oct 28, 2024

Attempt to handle errors in parallel level set discretization and surface analysis: due to lack of time, MPI_Abort calls are temporary used to avoid deadlocks in communications when one mpi process fail but not the others.

Algiane and others added 30 commits August 22, 2024 10:00
First attempt to maintain edge tags consistency in grp_split: for now, edges of xtetra of new mesh are updated if they belong to a boundary face.
Solves missing MG_NOM and MG_REF tags when a rank has a nom edge but without any physical boudary on it.
See the following test:
```
parmmg_debug TEST_OUTPUTS/sphere_nom_0-2.mesh -v 6 -centralized-output -metis-ratio 82 -noinsert -noswap -nomove -rn 0
```
… detection).

    Along // edges, non-manifold analysis and information sharing is done inside the PMMG_setdhd function, thus it was skipped in -nr mode.

    See the following test:
    ```
    parmmg_debug TEST_OUTPUTS/sphere_nom_0-2.mesh -v 6 -centralized-output -metis-ratio 82 -noinsert -noswap -nomove -rn 0 -nr
    ```
  - If a mesh is subdivided into 3 partitions with 3 MPI processes, an
edge provided as ref edge at input by the user will miss the MG_REF tag
if it blongs to only purely parallel faces on a partition. The tag is
suitably set to REF on the other partitions, leading to non-consistency.

  - fixes ls ls-DisIn-toygeom-faces-5 test case
… EDG tag at point along non EDG edge due to spurious input surface triangles matching the // interface).
…ot ad PARBDYBDY tags on temporary triangles that are finally deleted when storing the tags inside the xtetra.
@Algiane Algiane added part: parmmg specific to parmmg code part part: ls discretization isovalue mode specificty part: analysis labels Oct 28, 2024
@Algiane Algiane self-assigned this Oct 28, 2024
@Algiane Algiane merged commit 6c00cae into develop Oct 29, 2024
38 of 39 checks passed
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 51.47541% with 148 lines in your changes missing coverage. Please review.

Project coverage is 63.72%. Comparing base (8af189a) to head (20f7f86).
Report is 47 commits behind head on develop.

Files with missing lines Patch % Lines
src/analys_pmmg.c 50.36% 51 Missing and 17 partials ⚠️
src/ls_pmmg.c 25.42% 41 Missing and 3 partials ⚠️
src/loadbalancing_pmmg.c 50.00% 10 Missing ⚠️
src/libparmmg1.c 50.00% 8 Missing ⚠️
src/grpsplit_pmmg.c 80.55% 6 Missing and 1 partial ⚠️
src/overlap_pmmg.c 68.75% 3 Missing and 2 partials ⚠️
src/tag_pmmg.c 62.50% 3 Missing ⚠️
src/communicators_pmmg.c 0.00% 1 Missing and 1 partial ⚠️
src/hash_pmmg.c 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #132      +/-   ##
===========================================
- Coverage    63.76%   63.72%   -0.04%     
===========================================
  Files           47       47              
  Lines        19275    19419     +144     
  Branches      3600     3632      +32     
===========================================
+ Hits         12290    12375      +85     
- Misses        6056     6098      +42     
- Partials       929      946      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Algiane Algiane deleted the feature/error-handling-in-analysis branch October 31, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part: analysis part: ls discretization isovalue mode specificty part: parmmg specific to parmmg code part

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant