Remove dead code #127
Merged
Remove dead code #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a first place, Luca, that implemented the // analysis, guessed that some part of the analysis (such as the analysis of non-manifold situations) were not possible at the beginning of the process and have to be updated after interface migration. Finally, the non-manifold analysis is done during the pre-processing step and the 'update_nmgeom' function is not called anymore and can be removed.
Algiane
added
kind: cleanup
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #127 +/- ##
===========================================
+ Coverage 63.14% 63.31% +0.16%
===========================================
Files 46 46
Lines 18962 18913 -49
Branches 3548 3532 -16
===========================================
Hits 11974 11974
+ Misses 6060 6011 -49
Partials 928 928 ☔ View full report in Codecov by Sentry. |
laetitia-m
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part of code is not called anywhere.
After meeting with Luca that implemented it: it is now useless, the non-manifold analysis is now done during the preprocessing step.