Skip to content

Conversation

corentin-prigent
Copy link

@corentin-prigent corentin-prigent commented Jul 29, 2024

Prior to this update, edge owners were chosen as the lowest rank proc owning the edge. This could cause discrepancy with orientation rules for physical triangles, in the case where the lowest rank proc sees all the physical triangles as not well-oriented. This would cause the data relative to normal vectors not to be computed by any procs.
This update changes the owner assignement rule: owner is now the lowest rank proc among those who see the face as well oriented.
Added a function that check that among the whole mesh, every parallel edge has one and only one owner.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.

Project coverage is 63.07%. Comparing base (f8a5338) to head (c1d4939).

Files Patch % Lines
src/analys_pmmg.c 77.41% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #116      +/-   ##
===========================================
+ Coverage    63.06%   63.07%   +0.01%     
===========================================
  Files           46       46              
  Lines        18920    18947      +27     
  Branches      3532     3541       +9     
===========================================
+ Hits         11932    11951      +19     
- Misses        6066     6071       +5     
- Partials       922      925       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Algiane Algiane merged commit b80eeb2 into MmgTools:develop Aug 1, 2024
@Algiane
Copy link
Member

Algiane commented Aug 1, 2024

Thanks!

@Algiane Algiane self-requested a review August 1, 2024 12:14
@Algiane Algiane added kind: bug Something isn't working part: parmmg specific to parmmg code part part: surface specific to surface operators part: analysis labels Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: bug Something isn't working part: analysis part: parmmg specific to parmmg code part part: surface specific to surface operators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants