Feature/timing update requires signature

frontend/mina-signer/tests/party.test.ts

@@ -33,6 +33,7 @@ let otherParties = {
             setTokenSymbol: "Signature",
             incrementNonce: "Signature",
             setVotingFor: "Signature",
+            setTiming: "Signature",
           },
           zkappUri: null,
           tokenSymbol: null,

graphql_schema.json

@@ -1280,6 +1280,22 @@
               },
               "isDeprecated": false,
               "deprecationReason": null
+            },
+            {
+              "name": "setTiming",
+              "description": null,
+              "args": [],
+              "type": {
+                "kind": "NON_NULL",
+                "name": null,
+                "ofType": {
+                  "kind": "SCALAR",
+                  "name": "AuthRequired",
+                  "ofType": null
+                }
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
             }
           ],
           "inputFields": [
@@ -1436,6 +1452,20 @@
                 }
               },
               "defaultValue": null
+            },
+            {
+              "name": "setTiming",
+              "description": null,
+              "type": {
+                "kind": "NON_NULL",
+                "name": null,
+                "ofType": {
+                  "kind": "SCALAR",
+                  "name": "AuthRequired",
+                  "ofType": null
+                }
+              },
+              "defaultValue": null
             }
           ],
           "interfaces": null,
@@ -7955,6 +7985,22 @@
               },
               "isDeprecated": false,
               "deprecationReason": null
+            },
+            {
+              "name": "setTiming",
+              "description": null,
+              "args": [],
+              "type": {
+                "kind": "NON_NULL",
+                "name": null,
+                "ofType": {
+                  "kind": "SCALAR",
+                  "name": "AuthRequired",
+                  "ofType": null
+                }
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
             }
           ],
           "inputFields": null,
@@ -10891,6 +10937,23 @@
               },
               "isDeprecated": false,
               "deprecationReason": null
+            },
+            {
+              "name": "setTiming",
+              "description":
+                "Authorization required to set the timing of the account",
+              "args": [],
+              "type": {
+                "kind": "NON_NULL",
+                "name": null,
+                "ofType": {
+                  "kind": "ENUM",
+                  "name": "AccountAuthRequired",
+                  "ofType": null
+                }
+              },
+              "isDeprecated": false,
+              "deprecationReason": null
             }
           ],
           "inputFields": null,

src/app/archive/archive_lib/load_data.ml

@@ -174,6 +174,7 @@ let update_of_id pool update_id =
                   ; set_token_symbol
                   ; increment_nonce
                   ; set_voting_for
+                  ; set_timing
                   } =
             query_db ~f:(fun db -> Processor.Zkapp_permissions.load db id)
           in
@@ -190,6 +191,7 @@ let update_of_id pool update_id =
               ; set_token_symbol
               ; increment_nonce
               ; set_voting_for
+              ; set_timing
               }
               : Permissions.t ) )
     in
@@ -746,6 +748,7 @@ let get_account_accessed ~pool (account : Processor.Accounts_accessed.t) :
             ; set_token_symbol
             ; increment_nonce
             ; set_voting_for
+            ; set_timing
             } =
       query_db ~f:(fun db -> Processor.Zkapp_permissions.load db permissions_id)
     in
@@ -760,6 +763,7 @@ let get_account_accessed ~pool (account : Processor.Accounts_accessed.t) :
       ; set_token_symbol
       ; increment_nonce
       ; set_voting_for
+      ; set_timing
       }
       : Permissions.t )
   in

src/app/archive/archive_lib/processor.ml

@@ -402,6 +402,7 @@ module Zkapp_permissions = struct
     ; set_token_symbol : Permissions.Auth_required.t
     ; increment_nonce : Permissions.Auth_required.t
     ; set_voting_for : Permissions.Auth_required.t
+    ; set_timing : Permissions.Auth_required.t
     }
   [@@deriving fields, hlist]
 
@@ -418,6 +419,7 @@ module Zkapp_permissions = struct
       ; auth_required_typ
       ; auth_required_typ
       ; auth_required_typ
+      ; auth_required_typ
       ]
 
   let table_name = "zkapp_permissions"
@@ -435,6 +437,7 @@ module Zkapp_permissions = struct
       ; set_token_symbol = perms.set_token_symbol
       ; increment_nonce = perms.increment_nonce
       ; set_voting_for = perms.set_voting_for
+      ; set_timing = perms.set_timing
       }
     in
     Mina_caqti.select_insert_into_cols ~select:("id", Caqti_type.int)

src/app/archive/zkapp_tables.sql

@@ -85,6 +85,7 @@ CREATE TABLE zkapp_permissions
 , set_token_symbol         zkapp_auth_required_type    NOT NULL
 , increment_nonce          zkapp_auth_required_type    NOT NULL
 , set_voting_for           zkapp_auth_required_type    NOT NULL
+, set_timing               zkapp_auth_required_type    NOT NULL
 );
 
 CREATE TABLE zkapp_timing_info

src/app/replayer/test/archive_db.sql

@@ -1073,7 +1073,8 @@ CREATE TABLE public.zkapp_permissions (
     edit_sequence_state public.zkapp_auth_required_type NOT NULL,
     set_token_symbol public.zkapp_auth_required_type NOT NULL,
     increment_nonce public.zkapp_auth_required_type NOT NULL,
-    set_voting_for public.zkapp_auth_required_type NOT NULL
+    set_voting_for public.zkapp_auth_required_type NOT NULL,
+    set_timing public.zkapp_auth_required_type NOT NULL
 );
 
 
@@ -2434,7 +2435,7 @@ COPY public.zkapp_party_failures (id, index, failures) FROM stdin;
 -- Data for Name: zkapp_permissions; Type: TABLE DATA; Schema: public; Owner: -
 --
 
-COPY public.zkapp_permissions (id, edit_state, send, receive, set_delegate, set_permissions, set_verification_key, set_zkapp_uri, edit_sequence_state, set_token_symbol, increment_nonce, set_voting_for) FROM stdin;
+COPY public.zkapp_permissions (id, edit_state, send, receive, set_delegate, set_permissions, set_verification_key, set_zkapp_uri, edit_sequence_state, set_token_symbol, increment_nonce, set_voting_for, set_timing) FROM stdin;
 1	signature	signature	none	signature	signature	signature	signature	signature	signature	signature	signature
 2	proof	signature	none	signature	signature	signature	signature	proof	signature	signature	signature
 3	signature	either	either	either	either	either	either	either	either	either	either

src/app/zkapp_test_transaction/zkapp_test_transaction.ml

@@ -425,6 +425,9 @@ let update_permissions =
        and set_voting_for =
          Param.flag "--set-voting-for" ~doc:"Proof|Signature|Either|None"
            Param.(required string)
+       and set_timing =
+         Param.flag "--set-timing" ~doc:"Proof|Signature|Either|None"
+           Param.(required string)
        and current_auth =
          Param.flag "--current-auth"
            ~doc:
@@ -446,6 +449,7 @@ let update_permissions =
            ; set_token_symbol = Util.auth_of_string set_token_symbol
            ; increment_nonce = Util.auth_of_string increment_nonce
            ; set_voting_for = Util.auth_of_string set_voting_for
+           ; set_timing = Util.auth_of_string set_timing
            }
        in
        if Currency.Fee.(fee < Flags.min_fee) then

src/lib/genesis_ledger_helper/lib/genesis_ledger_helper_lib.ml

@@ -61,6 +61,7 @@ module Accounts = struct
             ; set_token_symbol
             ; increment_nonce
             ; set_voting_for
+            ; set_timing
             } ->
             let auth_required a =
               match a with
@@ -86,6 +87,7 @@ module Accounts = struct
             ; set_token_symbol = auth_required set_token_symbol
             ; increment_nonce = auth_required increment_nonce
             ; set_voting_for = auth_required set_voting_for
+            ; set_timing = auth_required set_timing
             }
       in
       let token_permissions =
@@ -241,6 +243,7 @@ module Accounts = struct
             ; set_token_symbol
             ; increment_nonce
             ; set_voting_for
+            ; set_timing
             } =
           account.permissions
         in
@@ -257,6 +260,7 @@ module Accounts = struct
           ; set_token_symbol = auth_required set_token_symbol
           ; increment_nonce = auth_required increment_nonce
           ; set_voting_for = auth_required set_voting_for
+          ; set_timing = auth_required set_timing
           }
       in
       let zkapp =

src/lib/integration_test_cloud_engine/kubernetes_network.ml

@@ -283,6 +283,7 @@ module Node = struct
                         setTokenSymbol
                         setVerificationKey
                         setVotingFor
+                        setTiming
                       }
           sequenceEvents
           zkappState
@@ -501,6 +502,7 @@ module Node = struct
     ; set_verification_key =
         to_auth_required account_permissions#setVerificationKey
     ; set_voting_for = to_auth_required account_permissions#setVotingFor
+    ; set_timing = to_auth_required account_permissions#setTiming
     }
 
   let graphql_uri node = Graphql.ingress_uri node |> Uri.to_string

src/lib/integration_test_cloud_engine/mina_automation.ml

@@ -187,6 +187,7 @@ module Network_config = struct
               ; set_token_symbol = None
               ; increment_nonce = None
               ; set_voting_for = None
+              ; set_timing = None
               }
           in
           let default = Runtime_config.Accounts.Single.default in

src/lib/mina_base/permissions.ml

@@ -319,6 +319,7 @@ module Poly = struct
         ; set_token_symbol : 'controller
         ; increment_nonce : 'controller
         ; set_voting_for : 'controller
+        ; set_timing : 'controller
         }
       [@@deriving annot, sexp, equal, compare, hash, yojson, hlist, fields]
     end
@@ -332,6 +333,7 @@ module Poly = struct
       ~receive:(f controller) ~set_zkapp_uri:(f controller)
       ~edit_sequence_state:(f controller) ~set_token_symbol:(f controller)
       ~increment_nonce:(f controller) ~set_voting_for:(f controller)
+      ~set_timing:(f controller)
     |> List.reduce_exn ~f:Random_oracle.Input.Chunked.append
 end
 
@@ -368,6 +370,7 @@ let gen ~auth_tag : t Quickcheck.Generator.t =
   let%bind set_token_symbol = auth_required_gen in
   let%bind increment_nonce = auth_required_gen in
   let%bind set_voting_for = auth_required_gen in
+  let%bind set_timing = auth_required_gen in
   return
     { Poly.edit_state
     ; send
@@ -380,6 +383,7 @@ let gen ~auth_tag : t Quickcheck.Generator.t =
     ; set_token_symbol
     ; increment_nonce
     ; set_voting_for
+    ; set_timing
     }
 
 [%%ifdef consensus_mechanism]
@@ -399,15 +403,15 @@ module Checked = struct
     Poly.Fields.map ~edit_state:c ~send:c ~receive:c ~set_delegate:c
       ~set_permissions:c ~set_verification_key:c ~set_zkapp_uri:c
       ~edit_sequence_state:c ~set_token_symbol:c ~increment_nonce:c
-      ~set_voting_for:c
+      ~set_voting_for:c ~set_timing:c
 
   let constant (t : Stable.Latest.t) : t =
     let open Core_kernel.Field in
     let a f = Auth_required.Checked.constant (get f t) in
     Poly.Fields.map ~edit_state:a ~send:a ~receive:a ~set_delegate:a
       ~set_permissions:a ~set_verification_key:a ~set_zkapp_uri:a
       ~edit_sequence_state:a ~set_token_symbol:a ~increment_nonce:a
-      ~set_voting_for:a
+      ~set_voting_for:a ~set_timing:a
 end
 
 let typ =
@@ -424,6 +428,7 @@ let typ =
     ; Auth_required.typ
     ; Auth_required.typ
     ; Auth_required.typ
+    ; Auth_required.typ
     ]
     ~var_to_hlist:to_hlist ~var_of_hlist:of_hlist ~value_to_hlist:to_hlist
     ~value_of_hlist:of_hlist
@@ -444,6 +449,7 @@ let user_default : t =
   ; set_token_symbol = Signature
   ; increment_nonce = Signature
   ; set_voting_for = Signature
+  ; set_timing = Signature
   }
 
 let empty : t =
@@ -458,6 +464,7 @@ let empty : t =
   ; set_token_symbol = None
   ; increment_nonce = None
   ; set_voting_for = None
+  ; set_timing = None
   }
 
 (* deriving-fields-related stuff *)
@@ -500,7 +507,7 @@ let deriver obj =
     ~set_permissions:!.auth_required ~set_verification_key:!.auth_required
     ~set_zkapp_uri:!.auth_required ~edit_sequence_state:!.auth_required
     ~set_token_symbol:!.auth_required ~increment_nonce:!.auth_required
-    ~set_voting_for:!.auth_required
+    ~set_voting_for:!.auth_required ~set_timing:!.auth_required
   |> finish "Permissions" ~t_toplevel_annots:Poly.t_toplevel_annots
 
 let%test_unit "json roundtrip" =
@@ -526,6 +533,7 @@ let%test_unit "json value" =
         editSequenceState: "Signature",
         setTokenSymbol: "Signature",
         incrementNonce: "Signature",
-        setVotingFor: "Signature"
+        setVotingFor: "Signature",
+        setTiming: "Signature"
       }|json}
     |> Yojson.Safe.from_string |> Yojson.Safe.to_string )

src/lib/mina_base/permissions.mli

@@ -55,6 +55,7 @@ module Poly : sig
         ; set_token_symbol : 'controller
         ; increment_nonce : 'controller
         ; set_voting_for : 'controller
+        ; set_timing : 'controller
         }
       [@@deriving sexp, equal, compare, hash, yojson, hlist, fields]
     end

src/lib/mina_generators/user_command_generators.ml

@@ -71,6 +71,7 @@ let parties_with_ledger () =
       ; set_token_symbol = Either
       ; increment_nonce = Either
       ; set_voting_for = Either
+      ; set_timing = Either
       }
     in
     let verification_key =

src/lib/mina_graphql/mina_graphql.ml

@@ -1081,6 +1081,11 @@ module Types = struct
               ~args:Arg.[]
               ~resolve:(fun _ permission ->
                 permission.Permissions.Poly.set_voting_for )
+          ; field "setTiming" ~typ:(non_null auth_required)
+              ~doc:"Authorization required to set the timing of the account"
+              ~args:Arg.[]
+              ~resolve:(fun _ permission ->
+                permission.Permissions.Poly.set_timing )
           ] )
 
     let account_vk =

src/lib/runtime_config/runtime_config.ml

@@ -121,6 +121,7 @@ module Json_layout = struct
           ; set_token_symbol : Auth_required.t [@default None]
           ; increment_nonce : Auth_required.t [@default None]
           ; set_voting_for : Auth_required.t [@default None]
+          ; set_timing : Auth_required.t [@default None]
           }
         [@@deriving yojson, dhall_type, sexp, bin_io_unversioned]
 
@@ -136,6 +137,7 @@ module Json_layout = struct
            ; "set_token_symbol"
            ; "increment_nonce"
            ; "set_voting_for"
+           ; "set_timing"
           |]
 
         let of_yojson json = of_yojson_generic ~fields of_yojson json