Skip to content

Conversation

@chakra-guy
Copy link
Collaborator

@chakra-guy chakra-guy commented May 19, 2025

Changes in the PR:

  • Better way to include/exclude certain rpc methods for tracking
  • Fixed provess.env being undefined
  • Added a missing sdk_action_requested event

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@chakra-guy chakra-guy requested a review from a team as a code owner May 19, 2025 09:39
@chakra-guy chakra-guy changed the title Update Analytics RPC Method tracklist Update Analytics RPC Method tracklist + Add missing event May 19, 2025
@chakra-guy chakra-guy changed the title Update Analytics RPC Method tracklist + Add missing event Updates and Fixes to Analytics May 19, 2025
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 94.28571% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.93%. Comparing base (6f00ebc) to head (d997974).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...SocketService/MessageHandlers/handleSendMessage.ts 57.14% 3 Missing ⚠️
...sdk-communication-layer/src/RemoteCommunication.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
+ Coverage   74.88%   74.93%   +0.05%     
==========================================
  Files         183      184       +1     
  Lines        4491     4513      +22     
  Branches     1108     1105       -3     
==========================================
+ Hits         3363     3382      +19     
- Misses       1128     1131       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

elribonazo
elribonazo previously approved these changes May 19, 2025
@christopherferreira9 christopherferreira9 added the deploy Deploys the test dapps label May 19, 2025
@sonarqubecloud
Copy link

@chakra-guy chakra-guy added deploy Deploys the test dapps and removed deploy Deploys the test dapps labels May 20, 2025
@chakra-guy chakra-guy added deploy Deploys the test dapps and removed deploy Deploys the test dapps labels May 20, 2025
@chakra-guy
Copy link
Collaborator Author

Missing sdk_action_requested event added.

Screenshot 2025-05-20 at 16 48 23

@chakra-guy chakra-guy enabled auto-merge (squash) May 20, 2025 14:49
@elribonazo elribonazo self-requested a review May 20, 2025 14:50
@chakra-guy chakra-guy merged commit b005ef2 into main May 20, 2025
31 of 32 checks passed
@chakra-guy chakra-guy deleted the fix-analytics branch May 20, 2025 14:51
@elribonazo elribonazo mentioned this pull request May 21, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy Deploys the test dapps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants