feat: implement message size validation to prevent excessive payloads #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added MAX_MESSAGE_LENGTH constant and implemented validation to ensure messages do not exceed the maximum allowed size in MobilePortStream and RemoteCommunicationPostMessageStream.
abretonc7s
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1197 +/- ##
==========================================
+ Coverage 74.02% 74.06% +0.04%
==========================================
Files 182 182
Lines 4343 4350 +7
Branches 1064 1066 +2
==========================================
+ Hits 3215 3222 +7
Misses 1128 1128 ☔ View full report in Codecov by Sentry. |
chakra-guy
reviewed
Jan 15, 2025
|
chakra-guy
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a 1MB message size limit for communication streams to prevent potential memory issues and DoS attacks.
Changes
MAX_MESSAGE_LENGTHconstant (1MB) in configSecurity Impact
Prevents potential denial of service attacks and memory issues from oversized messages in communication channels.