fix: correct event handler binding in modal components #1191
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
=======================================
Coverage 74.40% 74.40%
=======================================
Files 181 181
Lines 4306 4306
Branches 1057 1057
=======================================
Hits 3204 3204
Misses 1102 1102 ☔ View full report in Codecov by Sentry. |
|
chakra-guy
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overview
This PR fixes a scope-related bug in the modal components where event handlers were losing their
thiscontext. The issue affected click handlers in both the install and select modal components, potentially causing undefined errors when attempting to invoke methods.Impact
These changes fix potential runtime errors that could occur when users interact with modal buttons and overlays. No breaking changes or migration steps are required as this is a bug fix that maintains the existing API.