feat: improves the react connected hook when using extension & emit terminate when using extension #1186
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    


Explanation
This PR aims to improve the react connected hook when using the extension. Previously, the connected hook would always be true when using extension because
window.ethereum.isConnectedis always true as long as the extension is being detected. This now verifies if we have an account present meaning that it is actually connected to extension. If no account is present then it assumes it has been disconnected like mobile does (even though mobile relies on socket events to do this).Main changes:
connectingandconnectedconnectedbased on the existence of an account or not sincewindow.ethereum.isConnectedis always true if extension is installedBefore
Screen.Recording.2025-01-08.at.4.15.33.PM.mov
After
Screen.Recording.2025-01-08.at.4.14.26.PM.mov
The Terminate event can also be caught from the dapp side when using extension:
References
Checklist