refactor(sdk): always send RPC requests via network and deeplink #1181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved RPC method tracking logic to ensure it is executed before sending analytics. - Enhanced logging for the RPC method tracker to include detailed information about the tracked methods and data. - Removed redundant console warnings to clean up the code and improve readability.
abretonc7s
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
==========================================
- Coverage 74.14% 74.13% -0.02%
==========================================
Files 181 181
Lines 4305 4299 -6
Branches 1056 1053 -3
==========================================
- Hits 3192 3187 -5
+ Misses 1113 1112 -1 ☔ View full report in Codecov by Sentry. |
ecp4224
previously approved these changes
Dec 18, 2024
• Remove conditional analytics sending • Always send RPC requests via network • Add debug logging for triggeredInstaller state • Remove redundant RPC method tracking
abretonc7s
changed the title
|
|
First request analytics are coming through after connecting. Screen.Recording.2024-12-19.at.10.02.58.AM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the RPC message handling strategy by sending requests through both network and deeplink channels simultaneously, allowing the wallet to process whichever arrives first. This approach eliminates edge cases and improves reliability while maintaining backward compatibility.
Technical Details
Migration
No migration steps required. This is a transparent change that maintains backward compatibility.
Related: