fix: added skip modal for create wallet using SRP #37224
Closed
+404
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smgv
added
area-onboarding
needs-qa
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (1 files, +16 -0)
🔐 @MetaMask/web3auth (5 files, +364 -40)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [f7247b5]
UI Startup Metrics (1262 ± 87 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [93f9e7f]
UI Startup Metrics (1271 ± 89 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I have added the Skip SRP backup popover. When the user clicks on the "Remind me later" button, the user will see the popover where they can continue with SRP, or the user can skip the backup.
Jira Link: https://consensyssoftware.atlassian.net/browse/SL-237
Changelog
CHANGELOG entry: Added skip popover for SRP backup.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-10-27.at.2.21.17.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a confirmation popover when users choose “Remind me later” for SRP backup during onboarding, with updated telemetry, routing, locales, and tests.
SkipSRPBackuppopover (ui/pages/onboarding-flow/recovery-phrase/skip-srp-backup-popover.tsx) shown fromreview-recovery-phrase.jswhen clickingrecovery-phrase-remind-later.OnboardingWalletSecuritySkipInitiatedfrom review page; confirms/cancels in popover with corresponding MetaMetrics and trace events.ONBOARDING_METAMETRICSorONBOARDING_COMPLETION_ROUTEbased on browser/flow.skipAccountSecurity*inapp/_locales/en/messages.jsonandapp/_locales/en_GB/messages.json.test/e2e/.../secure-wallet-page.ts) to handle the popover (checkbox + confirm).Written by Cursor Bugbot for commit 93f9e7f. This will update automatically on new commits. Configure here.