chore: unassigned variables #37205
Merged
chore: unassigned variables #37205
+2
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [73522dc]
UI Startup Metrics (1268 ± 86 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ameliejyc
reviewed
Oct 30, 2025
There was a problem hiding this comment.
Should these be removed from Settings page also?
There was a problem hiding this comment.
Good catch! Removing some more... 🪓
n3ps
commented
Oct 30, 2025
| > | ||
| <Text | ||
| className={classnames({ | ||
| 'settings-page__subheader--link': initialBreadCrumbRoute, |
There was a problem hiding this comment.
with initialBreadCrumbRoute gone there was no point to the className and onClick
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [27e5d1c]
UI Startup Metrics (1267 ± 78 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ameliejyc
approved these changes
Oct 30, 2025
NidhiKJha
approved these changes
Oct 30, 2025
metamaskbot
added
the
release-13.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unassigned variables and dead code in Settings
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Removes unused breadcrumb-related props/markup from Settings and an unused error var in domain lookup, simplifying subheader rendering and updating stories/tests accordingly.
initialBreadCrumbKey,initialBreadCrumbRoute,breadCrumbTextKey) fromsettings.component.js, container, stories, and tests.Textheading; keep address trail for entry pages.errorvar and stop passing it tolookupEndinui/ducks/domains.js(logic otherwise unchanged).Written by Cursor Bugbot for commit 27e5d1c. This will update automatically on new commits. Configure here.