refactor: migrate components/app files to v5-compat #37204
+134
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (4 files, +17 -16)
👨🔧 @MetaMask/core-extension-ux (5 files, +65 -38)
🔄 @MetaMask/swaps-engineers (1 files, +3 -4)
|
DDDDDanica
force-pushed
the
refactor/app-components-v5-compat
branch
from
5de5042 to
10922ec
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [10922ec]
UI Startup Metrics (1252 ± 73 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
force-pushed
the
refactor/app-components-v5-compat
branch
from
10922ec to
a4caa9d
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [fda8ed3]
UI Startup Metrics (1276 ± 83 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
force-pushed
the
refactor/app-components-v5-compat
branch
from
fda8ed3 to
0bb1bb8
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [0bb1bb8]
UI Startup Metrics (1265 ± 82 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
force-pushed
the
refactor/app-components-v5-compat
branch
from
0bb1bb8 to
580fab6
Compare
DDDDDanica
commented
Oct 25, 2025
| const onHomeScreen = location.pathname === DEFAULT_ROUTE; | ||
| const onSettingsScreen = location.pathname.startsWith(SETTINGS_ROUTE); | ||
| // Use passed location or fallback to DEFAULT_ROUTE | ||
| const currentPathname = location?.pathname ?? DEFAULT_ROUTE; |
There was a problem hiding this comment.
ToastMaster was using useLocation() from v5-compat while being rendered in a v5 router context, causing the survey toast to not render correctly. By passing location as a prop rather than having the component fetch it via a mismatched router context can eliminate the router context mismatch.
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [580fab6]
UI Startup Metrics (1242 ± 72 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
DDDDDanica
force-pushed
the
refactor/app-components-v5-compat
branch
from
580fab6 to
9d27590
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [9d27590]
UI Startup Metrics (1280 ± 79 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate components/app files to v5-compat
Changelog
CHANGELOG entry: null
Related issues
Fixes: part of https://github.com/MetaMask/MetaMask-planning/issues/3261
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Replaces react-router-dom v5 APIs with v5-compat hooks (
useNavigate,useLocation) across app components, hooks, and tests, updates routing HOCs/utilities, and adjusts Toasts and Routes integration accordingly.react-router-domv5 APIs (useHistory,useLocation,withRouter) toreact-router-dom-v5-compathooks (useNavigate,useLocation) andwithRouterHooks.history.push/replacewithnavigate(...)across components and hooks (e.g.,ConnectedSnaps,ConvertTokenToNFTModal,TurnOnBackupAndSyncModal,TurnOnMetamaskNotifications,PasswordOutdatedModal,RecoveryPhraseReminder,TransactionListItem, bridge hooks).ToastMasterto acceptlocationvia props instead of reading it directly; wire it fromroutes.component.basic-configuration-modal: switch to v5-compatuseLocation.transaction-list-item-details.container: swapwithRouterforwithRouterHooks.useHandleSendNonEvmanduseBridgeTxHistoryData: useuseNavigatefor confirmations/tx-details navigation.react-router-dom-v5-compathooks and userender-helpers-navigate; adjust expectations fromhistory.pushtonavigateand passlocationwhere needed.Written by Cursor Bugbot for commit 9d27590. This will update automatically on new commits. Configure here.