Robocop 6.5.0: Problem with importing Sonarqube output

[robenie-cwt]

Robocop Version: 6.5.0
Sonarqube version: sonarqube:25.6.0.109173-community (2025.3)

Robocop executed command: robocop check --target-version 6 --reports sarif,sonarqube .
Sonarqube executed command: ./gradlew sonarqube -Dsonar.externalIssuesReportPaths=robocop_sonar_qube.json

During Sonarqube import, we got this error:

Sensor Import external issues report
Error during SonarScanner Engine execution
java.lang.IllegalArgumentException: 108 is not a valid line offset for pointer. File tests/acceptance-test/resources/card-details.robot has 107 character(s) at line 9
	at org.sonar.api.utils.Preconditions.checkArgument(Preconditions.java:43)
	at org.sonar.api.batch.fs.internal.DefaultInputFile.checkValid(DefaultInputFile.java:378)
	at org.sonar.api.batch.fs.internal.DefaultInputFile.newPointer(DefaultInputFile.java:311)
	at org.sonar.scanner.externalissue.ExternalIssueImporter.fillLocation(ExternalIssueImporter.java:203)
	at org.sonar.scanner.externalissue.ExternalIssueImporter.populateCommonValues(ExternalIssueImporter.java:123)
	at org.sonar.scanner.externalissue.ExternalIssueImporter.importIssue(ExternalIssueImporter.java:161)
	at org.sonar.scanner.externalissue.ExternalIssueImporter.importNewFormat(ExternalIssueImporter.java:92)
	at org.sonar.scanner.externalissue.ExternalIssueImporter.execute(ExternalIssueImporter.java:65)
	at org.sonar.scanner.externalissue.ExternalIssuesImportSensor.execute(ExternalIssuesImportSensor.java:75)
	at org.sonar.scanner.sensor.AbstractSensorWrapper.analyse(AbstractSensorWrapper.java:69)
	at org.sonar.scanner.sensor.ModuleSensorsExecutor.execute(ModuleSensorsExecutor.java:88)
	at org.sonar.scanner.sensor.ModuleSensorsExecutor.lambda$execute$1(ModuleSensorsExecutor.java:61)
	at org.sonar.scanner.sensor.ModuleSensorsExecutor.withModuleStrategy(ModuleSensorsExecutor.java:79)
	at org.sonar.scanner.sensor.ModuleSensorsExecutor.execute(ModuleSensorsExecutor.java:61)
	at org.sonar.scanner.scan.SpringModuleScanContainer.doAfterStart(SpringModuleScanContainer.java:80)
	at org.sonar.core.platform.SpringComponentContainer.startComponents(SpringComponentContainer.java:227)
	at org.sonar.core.platform.SpringComponentContainer.execute(SpringComponentContainer.java:206)
	at org.sonar.scanner.scan.SpringProjectScanContainer.scan(SpringProjectScanContainer.java:212)
	at org.sonar.scanner.scan.SpringProjectScanContainer.scanRecursively(SpringProjectScanContainer.java:208)
	at org.sonar.scanner.scan.SpringProjectScanContainer.doAfterStart(SpringProjectScanContainer.java:178)
	at org.sonar.core.platform.SpringComponentContainer.startComponents(SpringComponentContainer.java:227)
	at org.sonar.core.platform.SpringComponentContainer.execute(SpringComponentContainer.java:206)
	at org.sonar.scanner.bootstrap.SpringScannerContainer.doAfterStart(SpringScannerContainer.java:339)
	at org.sonar.core.platform.SpringComponentContainer.startComponents(SpringComponentContainer.java:227)
	at org.sonar.core.platform.SpringComponentContainer.execute(SpringComponentContainer.java:206)
	at org.sonar.scanner.bootstrap.SpringGlobalContainer.doAfterStart(SpringGlobalContainer.java:142)
	at org.sonar.core.platform.SpringComponentContainer.startComponents(SpringComponentContainer.java:227)
	at org.sonar.core.platform.SpringComponentContainer.execute(SpringComponentContainer.java:206)
	at org.sonar.scanner.bootstrap.ScannerMain.runScannerEngine(ScannerMain.java:150)
	at org.sonar.scanner.bootstrap.ScannerMain.run(ScannerMain.java:67)
	at org.sonar.scanner.bootstrap.ScannerMain.main(ScannerMain.java:53)
> Task :sonarqube FAILED

[bhirsz]

Thanks for the report - we already had similar in the past, but for different rules. SonarQube require stricly valid locations of rules and some rules may have reporting bugs. Also SonarQube have different approach for locations, for example we can't refer to empty space (even if it's spaces, so valid characters).

Do you know which rule in particular reports this issue at line 9? Or perhaps can you provide example line which causes problems?

[robenie-cwt]

@bhirsz I couldn't replicate the original issue as we have recently changed the ignored rules. But here is a new one. I think it is NAME04

INFO: Sensor Import external issues report
ERROR: Error during SonarScanner Engine execution
ERROR: java.lang.IllegalArgumentException: 98 is not a valid line offset for pointer. File tests/acceptance-test/resources/accounting-line-details.robot has 72 character(s) at line 57
	at org.sonar.api.utils.Preconditions.checkArgument(Preconditions.java:43)
	at org.sonar.api.batch.fs.internal.DefaultInputFile.checkValid(DefaultInputFile.java:378)
	at org.sonar.api.batch.fs.internal.DefaultInputFile.newPointer(DefaultInputFile.java:311)
	at org.sonar.scanner.externalissue.ExternalIssueImporter.fillLocation(ExternalIssueImporter.java:203)

Robocop CLI output:

tests/acceptance-test/resources/accounting-line-details.robot:57:1 NAME02 Keyword name 'Accounting line details are captured for order ATOC4_RefundCompleted_TnC' does not follow case convention
    |
 57 | Accounting line details are captured for order ATOC4_RefundCompleted_TnC
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ NAME02
 58 |     Verify that price breakdown list base amount admin fee are captured    ${empty}    ${empty}    ${empty}    ${empty}
 59 |     Verify that price breakdown list total amount admin fee are captured    ${empty}    ${empty}    ${empty}    ${empty}
    |

tests/acceptance-test/resources/accounting-line-details.robot:57:1 NAME04 Underscores in keyword name 'Accounting line details are captured for order ATOC4_RefundCompleted_TnC'
    |
 57 | Accounting line details are captured for order ATOC4_RefundCompleted_TnC
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ NAME04
 58 |     Verify that price breakdown list base amount admin fee are captured    ${empty}    ${empty}    ${empty}    ${empty}
 59 |     Verify that price breakdown list total amount admin fee are captured    ${empty}    ${empty}    ${empty}    ${empty}
    |

Actual Robot file at lines 57-59

Accounting line details are captured for order ATOC4_RefundCompleted_TnC
    Verify that price breakdown list base amount admin fee are captured    ${empty}    ${empty}    ${empty}    ${empty}
    Verify that price breakdown list total amount admin fee are captured    ${empty}    ${empty}    ${empty}    ${empty}

[bhirsz]

Looks like this is causing issues:

Accounting line details are captured for order ATOC4_RefundCompleted_TnC
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ NAME04

Is there whitespace (spaces / tabs) or robocop reports it incorrectly?

[robenie-cwt]

There are no whitespaces there. It seems like robocop reports it incorrectly

Other details of the file, it is using UTF-8 encoding and CRLF (Windows) for end of line markings

[bhirsz]

I see where the issue is - we use parent node as location. So end column is actually last line in keyword and that's why it's incorrectly reported. I will fix it

[robenie-cwt]

Hi @bhirsz . I have another one. And may be there are more? Do you want this reported separately?

Sonar import:

INFO: Sensor Import external issues report
ERROR: Error during SonarScanner Engine execution
ERROR: java.lang.IllegalArgumentException: 173 is not a valid line offset for pointer. File tests/acceptance-test/resources/common.robot has 172 character(s) at line 83
	at org.sonar.api.utils.Preconditions.checkArgument(Preconditions.java:43)

robocop CLI:

tests/acceptance-test/resources/common.robot:83:5 ARG07 There is too many arguments per continuation line (6 / 1)
    |
 81 |
 82 | Send payload to system
 83 |     [Arguments]    ${reservation_system_data}    ${locator_data}    ${creation_date_data}    ${version_timestamp_data}    ${email_itinerary_data}    ${expected_status_code}
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ARG07
 84 |     ...    ${expected_error_description}
 85 |     ${file_content}=    Get File    ${CURDIR}/data/postBooking_json.txt
    |

robocop sonarqube output file

{
      "ruleId": "ARG07",
      "primaryLocation": {
        "message": "There is too many arguments per continuation line (6 / 1)",
        "filePath": "tests/acceptance-test/resources/common.robot",
        "textRange": {
          "startLine": 83,
          "startColumn": 4,
          "endLine": 83,
          "endColumn": 173
        }
      }
    }

[bhirsz]

You can use this thread to report them - I will fix them as we go. With over 160 rules we already had some issues with location, and we may have more. In the example you added I see we're off by 1 character, I will also fix it (it will be deployed in the 6.5.1)

I could think about adding special test that would run roboocp on bigger codebase with all rules enabled and then compare if any reported line points to non existing line.

[robenie-cwt]

Another one. But this one, there is no specific file mentioned

Sonar:
ERROR: java.lang.IllegalArgumentException: A 'startColumn' [line=27, lineOffset=0] cannot be provided when the line is empty

But based on the result, I am guessing that this is the issue

robocop cli:

 26 |       And details are captured
 27 | /
 28 | |
    | |_^ SPC12
 29 |   #new scenarios

robocop sonar output:

{
      "ruleId": "SPC12",
      "primaryLocation": {
        "message": "Too many consecutive empty lines (2/1)",
        "filePath": "tests/acceptance-test/capture-details.robot",
        "textRange": {
          "startLine": 27,
          "startColumn": 0,
          "endLine": 28,
          "endColumn": 0
        }
      }
    }

[bhirsz]

Another one. But this one, there is no specific file mentioned

That's the issue I mentioned - SonarQube "doesn't like" reporting columns when the line is empty - I introduced workaround for it for some rules already, so I added this rule (SPC12) to this workaround

[bhirsz]

I have released version 6.5.1 with all above fixes. Please let me know if it helps