Skip to content

Conversation

@lucagiove
Copy link
Member

No description provided.

Breaking change with url partially defined in Create Session and * On Session keywords #329
@lucagiove lucagiove added this to the 0.9 milestone Apr 20, 2021
@lucagiove
Copy link
Member Author

@cloutierjo could you please install the 0.9.1a1 with pip install -U robotframework-requests --pre and make sure it behaves as expected?

NicoMincuzzi
NicoMincuzzi previously approved these changes Apr 21, 2021
@cloutierjo
Copy link

It does work for me. Thanks for the quick fix

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@34d89a6). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #330   +/-   ##
=========================================
  Coverage          ?   94.82%           
=========================================
  Files             ?       10           
  Lines             ?      483           
  Branches          ?       52           
=========================================
  Hits              ?      458           
  Misses            ?       22           
  Partials          ?        3           
Flag Coverage Δ
acceptance 92.54% <100.00%> (?)
unit 55.90% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/RequestsLibrary/__init__.py 100.00% <ø> (ø)
src/RequestsLibrary/RequestsKeywords.py 100.00% <100.00%> (ø)
src/RequestsLibrary/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34d89a6...419b4f5. Read the comment docs.

@lucagiove lucagiove merged commit 9d62731 into master Apr 22, 2021
@lucagiove lucagiove deleted the lucagiove/issue329 branch April 22, 2021 06:57
@lucagiove lucagiove added the bug label Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants