-
Notifications
You must be signed in to change notification settings - Fork 6
Init Manim Notebook walkthrough #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…hanges (as it will eventually)
Nice stuff! Some feedback:
FYI, I'm getting a bug in the 3rd cell "Make it red and fly away". Otherwise, this looks awesome! Let's get stuff in that wiki :) |
Thanks for your review!
For me, even if the terminal is hidden, when clicking on the
Not in the walkthrough itself, but we could as an example show a notification with the version. However, I didn't yet implement the version parsing in the background. But apparently, it would be useful to know the Manim version also in other places, so I will implement that in another PR and for now leave the behavior here as is (with terminal opening). Opened #97 for that.
Yes, because I thought it would be a bit weird if Manim would be executed for a file at some temporary location. But this is indeed a good point if users might directly click on the CodeLens without reading the comment beforehand first. I've added a new issue for this #96 and will fix this in another PR.
Thanks, good idea! By the way, have you also tested the commands that you can trigger by clicking on respective areas in the SVGs featured in the showcase? |
Correct, when I click that button the terminal does not open. See the log below -- neither click opened the terminal to show the manim version. See my new commit for fixing that with a simple
Yes it works as expected! Tabs may only be meaningful if there are multiple though 😂 |
Interesting thing to note -- I also use Cursor and it looks like Cursor does not support the walkthrough. When running the "Manim Notebook: Open Walkthrough" command I get the error
Not important enough to fix, just a note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works on my end with my VSCode and manimgl versions. I will approve this PR. @Splines when things are working for you, feel free to merge
yeah
😅
Sorry, but what is Cursor? Is it this editor? If yes, what's its relation to VSCode? |
Cursor is an AI-powered editor that integrates Claude/ChatGPT into your codebase to make it easy for an LLM to help you when writing code. It is a fork of VSCode, and in general gives you the familiar UX of vscode and supports the same extensions as VSCode. But it seems like they don't support walkthroughs 🤷. NBD, VSCode still has a much larger user base as Cursor is a paid product |
Closes #40
Description
We add a new walkthrough to welcome new users to our extension and to accompany them in their first steps.
And as noted in my comment here:
I've also created some SVGs in Figma that even feature some clickable areas... Try to find them ;)
Known limitations: Color theme
The Walkthrough best practices link to a Figma plugin called
Visual Studio Color Code Mapper
. This allows to use vscode internal CSS styles in the SVG such that it adapts to the user theme. I've experimented a lot with it, but the wizard that automatically assigns the correct CSS names doesn't work greatly. I.e. previewing in other color themes reveals that many elements were not mapped correctly and then suddenly adef
keyword doesn't have enough contrast in front of the editor background.So one would have to manually find out all the colors, e.g. color for python functions, parentheses etc. and that is just soo much work to do which I'd rather invest in developing new features or fixing bugs.