-
Notifications
You must be signed in to change notification settings - Fork 6
Add export scene codelens & wizard #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It works! 🎉🎉🎉 My initial impressions after playing around with it:
Additionally, we should copy the export command to the clipboard so users are able to play around with additional settings without losing the generated command. Also useful if a user does not want to use the built in terminal (e.g., a very long scene will take a while to generate and they want it to run in a dedicated terminal in a background) |
Also add a missing `await` statement.
Thanks for your review 🙏, yes both points absolutely make sense. I've addressed them in the newest commits. Please also review my "Note this comment" thread regarding the multi-step quick pick util file and resolve if d'accord. |
By the way, you can also post such comments as a review with the option Another advantage is that I can directly reply to your comment and resolve it later without cluttering the view. |
Sounds good @Splines! I have not yet figured the optimal way to exchange feedback on Github, thanks for your tip! :) I'm playing around with the changes you kindly implemented per my feedback, and I'm starting to prefer your original, simpler "Export" wording that you had before... Especially with the new alerts that are added, I think the process is more self-explanatory. Please see my small updates and see if you like the phrasing.
|
Closes #38.
Feature
Here we add the functionality to export a scene as described in my comment here. Or rather to be guided through some configuration to then obtain an executable command. This command will be pasted into a new terminal such that the user can review it and then execute it by pressing enter. This also allows to add any further flags before executing the command.
Known limitations
The action is triggered by a new codelens
Export Scene
at any line of Python code that defines a class. To limit this to classes that define Manim scenes, we can tackle #12 with the heuristic described there in a future PR.