Detect non-interactive scene start (preview whole scene) #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84. When starting the scene at a Python "class definition line", we don't start ManimGL in interactive mode (with
-se <line_number>
). Instead the whole scene is previewed (see the behavior ofstartStopScene.ts
). We now identify this scenario in theexecuteStartCommand()
method and wait not for the first IPython cell to finish, but for the first log info message to be shown:Known limitations
Preview Manim Cell
will just putcheckpoint_paste()
in the current terminal and therefore do nothing. But the nextPreview Manim Cell
will then succeed. If the user exits the shell after having previewed the whole scene, the nextPreview Manim Cell
will also work fine. I'd like to accept this as known limitation (or maybe if really needed tackle this case in a future PR where we should beforehand discuss what the expected behavior is in this case).